Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added console group APIs to NullConsole #9024

Merged
merged 3 commits into from
Oct 26, 2019
Merged

Conversation

eranimo
Copy link
Contributor

@eranimo eranimo commented Oct 8, 2019

Fixes #9018

Summary

This PR fixes the --silent CLI option, which previously didn't silence console group calls.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Could you add an entry to the changelog?

@jeysal
Copy link
Contributor

jeysal commented Oct 14, 2019

ping @eranimo :)
(let me know if I should add the changelog entry for you)

@codecov-io
Copy link

Codecov Report

Merging #9024 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9024   +/-   ##
=======================================
  Coverage   64.69%   64.69%           
=======================================
  Files         277      277           
  Lines       11701    11701           
  Branches     2873     2873           
=======================================
  Hits         7570     7570           
  Misses       3514     3514           
  Partials      617      617

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f448541...c442b43. Read the comment docs.

@SimenB SimenB merged commit 0c23c3b into jestjs:master Oct 26, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--silent shows console groups
5 participants