Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add util to create empty testResult #8867

Merged
merged 5 commits into from
Aug 22, 2019
Merged

Conversation

Mark1626
Copy link
Contributor

Summary

Based on a suggestion in #8823

Creating an util in @jest/test-result which will create an empty TestResult

/cc @SimenB

Test plan

Existing test cases should work after the change

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Please rebase on master and add a changelog entry

@Mark1626
Copy link
Contributor Author

Please rebase on master and add a changelog entry

It will go under as a feature right?

@SimenB
Copy link
Member

SimenB commented Aug 22, 2019

Please rebase on master and add a changelog entry

It will go under as a feature right?

Yup!

Mark1626 and others added 2 commits August 22, 2019 19:56
@@ -6,7 +6,7 @@
*/

import {Config} from '@jest/types';
import {AssertionResult, TestResult} from '@jest/test-result';
import {AssertionResult, TestResult, createEmptyTestResult} from '@jest/test-result';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier wants you to format this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I ran the lint with yarn lint:prettier, not sure why it wasn't caught

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that only runs on md files - you want yarn lint which runs eslint that we've configured to use with prettier

@SimenB SimenB merged commit 588f93a into jestjs:master Aug 22, 2019
@codecov-io
Copy link

Codecov Report

Merging #8867 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #8867      +/-   ##
=========================================
- Coverage   63.81%   63.8%   -0.01%     
=========================================
  Files         274     274              
  Lines       11574   11575       +1     
  Branches     2838    2837       -1     
=========================================
  Hits         7386    7386              
- Misses       3561    3562       +1     
  Partials      627     627
Impacted Files Coverage Δ
...us/src/legacy-code-todo-rewrite/jestAdapterInit.ts 0% <ø> (ø) ⬆️
packages/jest-jasmine2/src/reporter.ts 59.52% <ø> (ø) ⬆️
packages/jest-test-result/src/helpers.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16f7385...ed1b949. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants