CustomConsole: print console.error and console.assert to stderr #8261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubennorte
force-pushed
the
custom-console-error
branch
2 times, most recently
from
631e8ea to
6203ed6
Compare
scotthovestadt
approved these changes
Apr 3, 2019
|
@scotthovestadt yeah, we need to fix how we use stdio. #8091 aims to fix part of that |
|
I made a change so this only applies to |
rubennorte
commented
Apr 3, 2019
| expect(_stdout).toMatch('AssertionError'); | ||
| expect(_stdout).toMatch('false == true'); | ||
| expect(_stderr).toMatch('AssertionError'); | ||
| expect(_stderr).toMatch('The expression evaluated to a falsy value:'); |
There was a problem hiding this comment.
Node 11 tries to be smart printing the line that threw the error but it doesn't work well.
rubennorte
force-pushed
the
custom-console-error
branch
from
7a8ef47 to
5d0f9f2
Compare
SimenB
approved these changes
Apr 3, 2019
thymikee
approved these changes
Apr 3, 2019
This was referenced Mar 21, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using the CLI in
jest-runtime,console.error,console.warnandconsole.assertprint to stdout, which is wrong.CustomConsoleshould print to the givenstderrwhen calling those methods.Test plan
Added unit tests in
CustomConsole.