Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use types from @jest/reporter in @jest/core #8045

Merged
merged 2 commits into from
Mar 4, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Mar 4, 2019

Summary

Forgot to clean this up, and (probably due to a race condition due to missing references entry) this didn't show up on CI.

Test plan

Green CI

@@ -158,10 +158,20 @@ export default class ChildProcessWorker implements WorkerInterface {
}

getStdout(): NodeJS.ReadableStream {
if (this._child.stdout === null) {
throw new Error(
'stdout is null - this should never happen. Please open up an issue at https://github.com/facebook/jest',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when actually this can happen?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea. It's from DefinitelyTyped/DefinitelyTyped#33127

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

felt better to add an explicit error rather than ignoring the type error

@SimenB
Copy link
Member Author

SimenB commented Mar 4, 2019

I think typescript@3.3.3333 (what a version) surfaced this error, which is why I noticed it now

@@ -4,14 +4,14 @@
"rootDir": "src",
"outDir": "build"
},
// TODO: This is missing `@jest/reporters`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have done this when I merged #7994 yesterday 😅 The typings disagreed as well, interestingly enough (which is why it raised an error now)

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants