Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate jest-phabricator to TypeScript #7965

Merged
merged 4 commits into from
Feb 23, 2019

Conversation

r3nya
Copy link
Contributor

@r3nya r3nya commented Feb 23, 2019

Summary

Diff
diff --git a/packages/jest-phabricator/build/index.js b/packages/jest-phabricator/build/index.js
index a55e39432..5874e38b8 100644
--- a/packages/jest-phabricator/build/index.js
+++ b/packages/jest-phabricator/build/index.js
@@ -37,7 +37,6 @@ function _defineProperty(obj, key, value) {
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
- *
  */
 function summarize(coverageMap) {
   const summaries = Object.create(null);
@@ -62,7 +61,6 @@ function summarize(coverageMap) {
 }
 
 module.exports = function(results) {
-  // $FlowFixMe: This should work, but it does not.
   return _objectSpread({}, results, {
     coverageMap: results.coverageMap && summarize(results.coverageMap)
   });

Test plan

💚 build;

@r3nya r3nya force-pushed the migrate-jest-phabricator-to-ts branch from a0ddd16 to 06d20a9 Compare February 23, 2019 12:55
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks pretty good 🙂 Could you update the changelog and address the comment I added?

packages/jest-phabricator/src/index.ts Outdated Show resolved Hide resolved
@r3nya r3nya changed the title WIP: Migrate jest-phabricator to TypeScript Migrate jest-phabricator to TypeScript Feb 23, 2019
@r3nya r3nya marked this pull request as ready for review February 23, 2019 14:22
@r3nya
Copy link
Contributor Author

r3nya commented Feb 23, 2019

@SimenB I've applied your comments and added diff. Please take a look!

@SimenB
Copy link
Member

SimenB commented Feb 23, 2019

Gotta love that built diff. Thanks!

@SimenB SimenB merged commit 9a8cafe into jestjs:master Feb 23, 2019
@r3nya r3nya deleted the migrate-jest-phabricator-to-ts branch February 23, 2019 14:25
@r3nya
Copy link
Contributor Author

r3nya commented Feb 23, 2019

@SimenB thanks for your help!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants