Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Custom Matchers API example message property #7426

Merged
merged 2 commits into from
Nov 29, 2018
Merged

Fix Custom Matchers API example message property #7426

merged 2 commits into from
Nov 29, 2018

Conversation

patricknazar
Copy link
Contributor

@patricknazar patricknazar commented Nov 29, 2018

Summary

The example for a custom matcher 'message' property returns a string, it should be a function.

Test plan

Types of property 'message' are incompatible. Type 'string' is not assignable to type '() => string' so updated accordingly

message should return a function and not a constant
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@rickhanlonii rickhanlonii merged commit 0b3a645 into jestjs:master Nov 29, 2018
@@ -79,6 +79,7 @@

### Chore & Maintenance

- `[docs]` Fix message property in custom matcher example to return a function instead of a constant.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing link to this pr

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed #7429

@patricknazar patricknazar deleted the expect-api-typo branch November 29, 2018 11:05
captain-yossarian pushed a commit to captain-yossarian/jest that referenced this pull request Jul 18, 2019
* (fix) message should return a function

message should return a function and not a constant

* Update CHANGELOG.md
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants