Add computeSha1 option #7345
Merged
Add computeSha1 option #7345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubennorte
force-pushed
the
add-compute-sha1-option
branch
from
9dc32a4
to
ea9d969
Compare
|
Related to #7124? EDIT: No, that's access time, not modified time |
rubennorte
force-pushed
the
add-compute-sha1-option
branch
from
ea9d969
to
ad0f335
Compare
rubennorte
force-pushed
the
add-compute-sha1-option
branch
from
ad0f335
to
0dbf46e
Compare
|
Can you explain why this option was added? How do you expect this to be used? |
|
This option was added to be able to reuse haste map entries for files whose mtime has changed but the sha-1 has not. It basically allows us to use remote caching relying on the actual contents of the file rather than its state in the current filesystem. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The HasteMap class has an option to compute the sha-1 of files and use it to determine if a file has changed if the modification times differ. This is used by external packages (e.g. Metro) but the option wasn't exposed in Jest. It's exposed as an option instead of enabling it by default because it has a performance impact that only pays off for some use cases (like remote caching, where mtimes differ).
Test plan
This is difficult to test e2e (as it'll mostly be used with watchman and remote caching where mtime is lost) and we don't test that options are forwarded in the different packages in unit tests, so I trust Flow typing and manual testing here.