Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "clover" to coverageReports default value #7126

Merged
merged 3 commits into from
Oct 9, 2018

Conversation

lychyi
Copy link
Contributor

@lychyi lychyi commented Oct 9, 2018

Summary

The configuration docs indicate that the default coverageReporters value is ["json", "lcov", "text", "clover"]. However, the default values (this should be for all versions of the docs) have also included "clover" as one of the reporters. So by default, a clover.xml file will be generated.

Test plan

Here it is on my local (highlight is from cmd/ctrl + F in Chrome):

screen shot 2018-10-08 at 6 00 03 pm

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimenB SimenB merged commit a168b34 into jestjs:master Oct 9, 2018
@lychyi lychyi deleted the coverage-reporters-doc-fix branch October 9, 2018 06:15
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants