Avoid loading files that we know are binary ahead of time #5612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpojer
reviewed
Feb 19, 2018
| '.ttf', | ||
| '.woff', | ||
| '.woff2', | ||
| ].sort()); |
There was a problem hiding this comment.
why do we need to sort this? This seems like unnecessary overhead to do in every worker. Can you just alt+f5 it upfront?
Codecov Report
@@ Coverage Diff @@
## master #5612 +/- ##
==========================================
+ Coverage 60.63% 60.64% +<.01%
==========================================
Files 213 214 +1
Lines 7311 7315 +4
Branches 3 3
==========================================
+ Hits 4433 4436 +3
- Misses 2877 2878 +1
Partials 1 1
Continue to review full report at Codecov.
|
This was referenced Feb 20, 2018
This was referenced Mar 1, 2018
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids
jest-haste-mapreading formats we know they are binary, even when requested to do so viaextensions. This fixes a bug in Metro, where, in order to process assets, we need to pass Haste the corresponding extensions, but causes an OOM when opening a ~600 Mb video.