Do not call toJSON recursively in pretty-format

[pedrottimark]

Fixes #4956

If the returned value also has toJSON method:

• It can cause an error: Maximum call stack size exceeded
• It customizes stringification behavior beyond the contract with JSON.stringify: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify#toJSON()_behavior

Can y’all think of another way to fix this?

I don’t think plugins need another arg. However, they can call printer with optional arg if needed.

Test plan

Updated title and expected result of existing test

[codecov-io]

Codecov Report

Merging #5044 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #5044   +/-   ##
=======================================
  Coverage   60.74%   60.74%           
=======================================
  Files         198      198           
  Lines        6605     6605           
  Branches        4        4           
=======================================
  Hits         4012     4012           
  Misses       2593     2593

Impacted Files	Coverage Δ
packages/pretty-format/src/index.js	96.45% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6383322...eb4b06e. Read the comment docs.

[pedrottimark]

AppVeyor build failed: no escape codes for colors in snapshots? I thought that had been fixed.

[cpojer]

What if one object's toJSON returns another object's toJSON that would not lead to recursion? I think this fix here is fine, but we may want to consider adding a circular reference counter instead.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.