Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefer-to-have-length rule to eslint-plugin-jest package #4771

Merged
merged 1 commit into from
Oct 30, 2017

Conversation

xfumihiro
Copy link
Contributor

No description provided.

@SimenB
Copy link
Member

SimenB commented Oct 26, 2017

I like it, but I'm guessing @cpojer would prefer to not have it bundled.

If he does not want it, I suggest we create an eslint-plugin-jest-extras or something and stick it in https://github.com/jest-community/

(there are more rules I'd like that are more nice-to-haves than anything else)

@xfumihiro xfumihiro force-pushed the eslint_prefer_tohavelength branch from d518e11 to 34de38e Compare October 26, 2017 14:23
@cpojer
Copy link
Member

cpojer commented Oct 26, 2017

I like it also, actually. This makes sense to me for better failure messages.

@xfumihiro xfumihiro force-pushed the eslint_prefer_tohavelength branch 5 times, most recently from d37e434 to 4127fbe Compare October 26, 2017 15:48
@codecov-io
Copy link

Codecov Report

Merging #4771 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4771      +/-   ##
=========================================
+ Coverage   58.94%     59%   +0.06%     
=========================================
  Files         199     200       +1     
  Lines        6630    6626       -4     
  Branches        3       4       +1     
=========================================
+ Hits         3908    3910       +2     
+ Misses       2722    2716       -6
Impacted Files Coverage Δ
packages/eslint-plugin-jest/src/index.js 100% <ø> (ø) ⬆️
...int-plugin-jest/src/rules/prefer_to_have_length.js 100% <100%> (ø)
packages/jest-environment-jsdom/src/index.js 38.88% <0%> (-1.54%) ⬇️
packages/jest-config/src/normalize.js 92.68% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfbda80...4127fbe. Read the comment docs.

@xfumihiro xfumihiro force-pushed the eslint_prefer_tohavelength branch from 4127fbe to 85f03b9 Compare October 26, 2017 17:38
@SimenB
Copy link
Member

SimenB commented Oct 29, 2017

@xfumihiro Can you make this, and the others you sent (woo! thanks!), fixable? Should be straightforward 🙂

@xfumihiro xfumihiro force-pushed the eslint_prefer_tohavelength branch from 85f03b9 to 928286a Compare October 29, 2017 14:36
@xfumihiro xfumihiro force-pushed the eslint_prefer_tohavelength branch from 928286a to c6ca332 Compare October 29, 2017 14:53
@xfumihiro
Copy link
Contributor Author

@SimenB Done

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants