Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove existing throw #4417

Merged
merged 1 commit into from
Sep 4, 2017
Merged

Remove existing throw #4417

merged 1 commit into from
Sep 4, 2017

Conversation

mjesun
Copy link
Contributor

@mjesun mjesun commented Sep 4, 2017

Summary

The throw was added to clarify a complex behavior, like matching --onlyChanged with a pattern. However, this makes impossible to have a default to run tests related to the commit that can also be overridden via CLI with --all, or use a pattern. Which, in fact, it already existed.

Test plan

Run jest --onlyChanged foo; and all foo tests should be run without throwing an exception. This is because the pattern will take precedence over --onlyChanged.

@codecov-io
Copy link

Codecov Report

Merging #4417 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4417   +/-   ##
=======================================
  Coverage   56.84%   56.84%           
=======================================
  Files         191      191           
  Lines        6472     6472           
  Branches        6        6           
=======================================
  Hits         3679     3679           
  Misses       2790     2790           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be4bec3...0c28f0a. Read the comment docs.

@cpojer cpojer merged commit a8be52b into jestjs:master Sep 4, 2017
@mjesun mjesun deleted the remove-throw branch December 6, 2017 11:47
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants