Make Jest's Test Runner configurable. #4240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Aug 10, 2017
| contexts.forEach(({config}) => { | ||
| if (!testRunners[config.runner]) { | ||
| // $FlowFixMe | ||
| testRunners[config.runner] = new (require(config.runner))( |
There was a problem hiding this comment.
Maybe not at this point, but eventually it would be nice to guard that expression and throw a human readable error.
There was a problem hiding this comment.
Also, maybe we can cast a TestRunner type here?
thymikee
reviewed
Aug 10, 2017
| } | ||
| }); | ||
|
|
||
| const testRuns = this._partitionTests(testRunners, tests); |
There was a problem hiding this comment.
testsByRunner seems more appropriate to me.
|
You need to update the config snapshot |
cpojer
force-pushed
the
master
branch
3 times, most recently
from
a4cddb0
to
2ddb379
Compare
cpojer
changed the title
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds a
runneroption toProjectConfigthat points tojest-runnerbut can be customized per project to any test runner. To ensure performance doesn't suffer with this new feature when using the MPR, multiple contexts that point to the same runner are merged and tests are run in the same runner instance, rather than creating a new instance per context. This means that there should be no performance penalty for existing MPR projects.This is conflicting somewhat with the
testRunneroption that allows to pickjest-jasmine2orjest-circus, however in this new world ProjectConfigs will be entirely jest-runner specific and variadic, and out of Jest's immediate control, so I don't think this matters long term and there are pending changes to be made to configs to support that. I think it makes more sense to consider this option therunner, add an optionlibrary(for lack of a better name) which replacestestRunner. I think we can make this decision later and I expect there to be morerunners thantestRunners going forward, so we may even want to kill the setting entirely and make therunneras compose-able as possible.Test plan
jest + manual verification that it only creates one runner for the MPR right now.