Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling for --config #4230

Merged
merged 3 commits into from
Aug 10, 2017
Merged

Conversation

rogeliog
Copy link
Contributor

@rogeliog rogeliog commented Aug 9, 2017

Summary

#4194

Adds error handling for the --config argument.

  • Handles error for invalid JSON object
  • Handles error for invalid files that are not .js or .json

Test plan

config-errors

Quick question: Is there a place that I can add some tests for this?

@codecov-io
Copy link

Codecov Report

Merging #4230 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4230      +/-   ##
==========================================
- Coverage   60.13%   60.12%   -0.02%     
==========================================
  Files         191      191              
  Lines        6756     6758       +2     
  Branches        6        6              
==========================================
  Hits         4063     4063              
- Misses       2690     2692       +2     
  Partials        3        3
Impacted Files Coverage Δ
packages/jest-config/src/index.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d0a434...ffed3dd. Read the comment docs.

@cpojer cpojer merged commit e16ce6b into jestjs:master Aug 10, 2017
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
* Better error handling for --config

* Check for arg.config

* Update index.js
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants