Test empty Immutable collections with {min: false} option

[pedrottimark]

Summary

Explicitly specify expected result to prevent regression during work on pretty-format plugins :)

@cpenarrieta can you please confirm? Thank you!

Immutable.OrderedSet [
]
// and so on for {min: false} option

Test plan

Added 8 tests

[cpenarrieta]

@pedrottimark LGTM

[aaronabramov]

i think for pretty-format we should have a more generic test suite.
I was thinking about something like:

const datastructureUnderTest = [
  new Set(),
  new Set([1, "a", Infinity, undefined, null]),
  new Map(),
  new Map([[1, 2], [3, 4]]),
  "string",
  123,
  new Set([
    new Map(),
    new Set([1]),
  ]),
  // etc...
];

expect(prettyPrint(datastructureUnderTest)).toMatchSnapshot();

i think these tests will be easire to write/fix/understand

[cpojer]

Seems like it is failing CI.

[thymikee]

@aaronabramov couldn't agree more. Snapshots would be perfect for testing pretty format output.

[cpojer]

I don't agree. Self-hosting the pretty-format tests will lead to weirdness.

[thymikee]

😞 thought about it for a while, but it was so tempting I forgot...

[pedrottimark]

I fixed 2 prettier lint errors (careless me).

Now CircleCI fails with segmentation fault during integration tests in test-ci-partial for Node.js 4

[cpojer]

Awesome!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.