Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mockImplemetation() resets the returnValue flag, but not the actual value #3933

Merged
merged 1 commit into from
Jun 29, 2017

Conversation

aaronabramov
Copy link
Contributor

fixes #3928

@codecov-io
Copy link

Codecov Report

Merging #3933 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3933      +/-   ##
=========================================
+ Coverage    58.1%   58.1%   +<.01%     
=========================================
  Files         196     196              
  Lines        6752    6753       +1     
  Branches        6       6              
=========================================
+ Hits         3923    3924       +1     
  Misses       2826    2826              
  Partials        3       3
Impacted Files Coverage Δ
packages/jest-mock/src/index.js 91.92% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac25993...2369877. Read the comment docs.

@cpojer cpojer merged commit eb9be5a into jestjs:master Jun 29, 2017
@aaronabramov aaronabramov deleted the fix-mock-implementation branch June 29, 2017 16:57
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mockReturnValue overwrites mockImplementation
5 participants