Adding .hasAssertions to expect API #3379

anilreddykatta · 2017-04-27T03:01:34Z

Updated docs for .hasAssertions API Change
Added test cases in integration-tests
Removed yarn.lock from pull request

Summary

Test plan
Unit test cases along with integration tests have been added.

codecov-io · 2017-04-27T03:27:39Z

Codecov Report

Merging #3379 into master will decrease coverage by 0.04%.
The diff coverage is 47.05%.

@@            Coverage Diff             @@
##           master    #3379      +/-   ##
==========================================
- Coverage   64.09%   64.04%   -0.05%     
==========================================
  Files         177      177              
  Lines        6561     6570       +9     
  Branches        4        4              
==========================================
+ Hits         4205     4208       +3     
- Misses       2355     2361       +6     
  Partials        1        1

Impacted Files	Coverage Δ
...ges/pretty-format/src/plugins/AsymmetricMatcher.js	`100% <ø> (ø)`	⬆️
packages/jest-jasmine2/src/setup-jest-globals.js	`0% <0%> (ø)`	⬆️
packages/jest-jasmine2/src/jest-expect.js	`0% <0%> (ø)`	⬆️
packages/jest-matchers/src/index.js	`95.4% <100%> (+0.16%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3efa3b9...9ff3ce0. Read the comment docs.

thymikee

Nice work! Left some inline comments for you.

thymikee · 2017-04-27T19:18:39Z

integration_tests/__tests__/__snapshots__/failures-test.js.snap

+
+    expect.hasAssertions()
+
+    Expected at least one assertion to be called but no assertions were called.


Expected at least one assertion to be called but received none.

maybe?

thymikee · 2017-04-27T19:30:48Z

packages/jest-matchers/src/index.js

@@ -57,6 +57,7 @@ if (!global[GLOBAL_STATE]) {
      state: {
        assertionCalls: 0,
        assertionsExpected: null,
+        expectedAssertions: false,


How about:

expectedAssertionsNumber: null, isExpectingAssertions: false,

Seems a bit more descriptive. assertionsExpected and expectedAssertions don't tell much to me.

thymikee · 2017-04-27T21:26:29Z

cc: @mxstbr

mxstbr

Awesome, looks great!

cpojer · 2017-04-28T16:25:38Z

Alright, I fixed everything up and made the flow typing a bit better so that all of this is actually working properly :)

2. Added test cases in `integration-tests` 3. Removed `yarn.lock` from pull request

Rebasing with master, resolved conflicts

SimenB · 2017-04-28T17:26:50Z

Should be added here, right? https://github.com/facebook/jest/blob/master/packages/eslint-plugin-jest/src/rules/valid-expect.js#L19

anilreddykatta · 2017-04-28T18:06:55Z

Thanks @cpojer

cpojer · 2017-04-28T19:17:49Z

@SimenB yes! @anilreddykatta do you wanna send a PR for the eslint plugin change? :)

SimenB · 2017-04-29T00:07:41Z

Might actually have to update the code there, unsure if it handles a function directly on expect now (which is no error was triggered by the linter now)

anilreddykatta · 2017-04-29T03:24:23Z

@cpojer I didn't quite get what you mean. Do you mind elaborating a bit? I can definitely raise a PR. 😄

diegohaz · 2017-05-01T04:54:28Z

Just adding the issue reference so people can find it: #3359

SimenB · 2017-05-01T08:08:04Z

@anilreddykatta It was a bit more involved than just adding to an array, so I sent a PR for it: #3426

* 1. Updated docs for `.hasAssertions` API Change 2. Added test cases in `integration-tests` 3. Removed `yarn.lock` from pull request * Adding suggested changes Rebasing with master, resolved conflicts * Fixes + improved flow types.

github-actions · 2021-05-13T17:24:52Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

facebook-github-bot added the CLA Signed ✔️ label Apr 27, 2017

thymikee mentioned this pull request Apr 27, 2017

expect.hasAssertions() #3371

Closed

thymikee requested changes Apr 27, 2017

View reviewed changes

thymikee approved these changes Apr 27, 2017

View reviewed changes

mxstbr approved these changes Apr 28, 2017

View reviewed changes

anilreddykatta and others added 3 commits April 28, 2017 17:27

1. Updated docs for .hasAssertions API Change

e079553

2. Added test cases in `integration-tests` 3. Removed `yarn.lock` from pull request

Adding suggested changes

b556831

Rebasing with master, resolved conflicts

Fixes + improved flow types.

9ff3ce0

cpojer merged commit e56103c into jestjs:master Apr 28, 2017

github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding .hasAssertions to expect API #3379

Adding .hasAssertions to expect API #3379

anilreddykatta commented Apr 27, 2017 •

edited

Loading

codecov-io commented Apr 27, 2017 •

edited

Loading

thymikee left a comment

thymikee Apr 27, 2017

thymikee Apr 27, 2017

thymikee commented Apr 27, 2017

mxstbr left a comment

cpojer commented Apr 28, 2017

SimenB commented Apr 28, 2017

anilreddykatta commented Apr 28, 2017

cpojer commented Apr 28, 2017

SimenB commented Apr 29, 2017

anilreddykatta commented Apr 29, 2017

diegohaz commented May 1, 2017

SimenB commented May 1, 2017

github-actions bot commented May 13, 2021


		expect.hasAssertions()

		Expected at least one assertion to be called but no assertions were called.

Adding .hasAssertions to expect API #3379

Adding .hasAssertions to expect API #3379

Conversation

anilreddykatta commented Apr 27, 2017 • edited Loading

codecov-io commented Apr 27, 2017 • edited Loading

Codecov Report

thymikee left a comment

Choose a reason for hiding this comment

thymikee Apr 27, 2017

Choose a reason for hiding this comment

thymikee Apr 27, 2017

Choose a reason for hiding this comment

thymikee commented Apr 27, 2017

mxstbr left a comment

Choose a reason for hiding this comment

cpojer commented Apr 28, 2017

SimenB commented Apr 28, 2017

anilreddykatta commented Apr 28, 2017

cpojer commented Apr 28, 2017

SimenB commented Apr 29, 2017

anilreddykatta commented Apr 29, 2017

diegohaz commented May 1, 2017

SimenB commented May 1, 2017

github-actions bot commented May 13, 2021

anilreddykatta commented Apr 27, 2017 •

edited

Loading

codecov-io commented Apr 27, 2017 •

edited

Loading