Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clears screen during watch mode correctly. #3294

Merged
merged 1 commit into from
Apr 13, 2017

Conversation

marr
Copy link
Contributor

@marr marr commented Apr 12, 2017

Summary
This change is to prevent the screen from clearing when building for Continuous Integration systems. While the --watch flag typically wouldn't be used on a CI system, this change gives us a hook into disabling the clear feature that can prevent other processes' output from being seen during a typical development workflow.

Test plan
I was able to verify this worked using the CI=true jest --watchAll npm-script in my project. Without the CI value set, the standard behavior of the screen clearing between watch runs, occurs.

Fixes #2959.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@marr marr changed the title Clears screen during watch mode correctly. (#2959) Clears screen during watch mode correctly. Apr 12, 2017
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@cpojer cpojer merged commit d9c2f99 into jestjs:master Apr 13, 2017
@cpojer
Copy link
Member

cpojer commented Apr 13, 2017

Thank you so much for fixing this! I'm sorry for the thrash on that issue, my mistake and I apologize.

skovhus pushed a commit to skovhus/jest that referenced this pull request Apr 29, 2017
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make console clearing with --watch optional
4 participants