Fix done.fail not passing arguments #3241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
commented
Apr 1, 2017
| }; | ||
| await queueRunner(options); | ||
|
|
||
| expect(options.fail).toHaveBeenCalledWith('miserably', 'failed'); |
There was a problem hiding this comment.
@jwbay it gets called now!
Codecov Report
@@ Coverage Diff @@
## master #3241 +/- ##
=========================================
- Coverage 64.19% 63.6% -0.59%
=========================================
Files 141 175 +34
Lines 5457 6433 +976
Branches 4 4
=========================================
+ Hits 3503 4092 +589
- Misses 1953 2340 +387
Partials 1 1
Continue to review full report at Codecov.
|
skovhus
pushed a commit
to skovhus/jest
that referenced
this pull request
Apr 29, 2017
* Fix done.fail context issue * Use concat instead of spread to fix node 4
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
* Fix done.fail context issue * Use concat instead of spread to fix node 4
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
done.fail()not passing arguments. Arrow functions don't bindarguments, so I used a regular function instead.Thanks @jwbay.
Test plan
Added a test for that.