Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade write-file-atomic to v4 #13853

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

andrewiggins
Copy link
Contributor

Summary

Hello! When trying to install the latest version of Jest (v29.4.1) I'm getting the following error when using yarn: write-file-atomic@5.0.0: The engine "node" is incompatible with this module. Expected version "^14.17.0 || ^16.13.0 || >=18.0.0". Got "16.10.0". Unfortunately, upgrading my project's node version is a large undertaking that will take a lot of time and involve a couple different teams. So I wanted to pass by you the idea of downgrading write-file-atomic for the time being so I can take advantage of the latest Jest features before upgrading my Node version (and perhaps make upgrading easier for anyone else in a similar situation using Node < 16.13 + yarn). Though I understand if you'd rather not. Just thought I'd ask 😊

Some additional context:
In v29.4.0 in PR #13703, the write-file-atomic was upgraded from v4.0.1 to v5.0.0. Glancing at the changes from v4.0.2...v5.0.0 in write-file-atomic (changelog, commits), I don't see any code changes besides the engines bump. So I believe it is safe to downgrade.

Test plan

Tests pass locally for me.

@andrewiggins andrewiggins changed the title Downgrade write-file-atomic to ^4.0.2 Downgrade write-file-atomic to ^4.0.1 Feb 2, 2023
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍 Didn't notice write-file-atomic range being outside of our own

@SimenB SimenB force-pushed the downgrade-write-file-atomic branch from 247e450 to b4c01e2 Compare February 7, 2023 10:45
@SimenB SimenB changed the title Downgrade write-file-atomic to ^4.0.1 Downgrade write-file-atomic to v4 Feb 7, 2023
@SimenB SimenB merged commit 8313d00 into jestjs:main Feb 7, 2023
@SimenB
Copy link
Member

SimenB commented Feb 7, 2023

https://github.com/facebook/jest/releases/tag/v29.4.2

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants