Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicit how to set n parameter to --bail #13128

Merged
merged 1 commit into from
Aug 13, 2022
Merged

explicit how to set n parameter to --bail #13128

merged 1 commit into from
Aug 13, 2022

Conversation

Trim
Copy link
Contributor

@Trim Trim commented Aug 12, 2022

Summary

The equal sign is required between --bail and n, otherwise the number n will be used as a test file filter.

Test plan

There's no code, only documentation update.

@facebook-github-bot
Copy link
Contributor

Hi @Trim!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you update all versions of this doc?

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Trim
Copy link
Contributor Author

Trim commented Aug 13, 2022

Thanks! Could you update all versions of this doc?

You're welcome. Where are the other versions?

I found them on the gh-pages branch. Should I create a PR to update this branch directly ?

@mrazauskas
Copy link
Contributor

On the main branch in website/versioned_docs directory (;

@SimenB
Copy link
Member

SimenB commented Aug 13, 2022

Yep

image

@Trim
Copy link
Contributor Author

Trim commented Aug 13, 2022

Well, I've just done the update for version 25 to 28.1, thanks 👍

docs/CLI.md Outdated Show resolved Hide resolved
The equal sign is required between `--bail` and `n`, otherwise the number `n`
will be used as a test file filter.
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit ae8cf9a into jestjs:main Aug 13, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants