chore: add noImplicitOverride check
#12648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
This reverts commit 8bfc643.
mrazauskas
commented
Apr 7, 2022
| @@ -12,6 +12,7 @@ | |||
| /* Additional Checks */ | |||
| "noUnusedLocals": true, | |||
| "noUnusedParameters": true, | |||
| "noImplicitOverride": true, | |||
There was a problem hiding this comment.
Type tests on TS 4.2 do not work with this option. I could move it to tsconfig.json inside package directories. Not sure if that is worth it.
|
I like it! I'm also fine with setting 4.3 as minimum 🙂 |
SimenB
reviewed
Apr 8, 2022
|
should we merge in |
|
Should update https://github.com/facebook/jest/blob/420ba4535b4563909d8b3a51fd97a3619c5f10d1/.github/workflows/nodejs.yml#L58 as well (but wait for CI to complete and I can merge) |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The code base is huge, it might be useful to add TypeScript’s
noImplicitOverridecheck. I think there is a benefit in it. Or?EDIT: oh.. this is a feature of TS v4.3. In the other hand,
overrideis only relevant at build time, so perhaps that‘s fine?Test plan
Green CI.