feat(@jest/transform)!: require process() and processAsync() methods to always return structured data
#12638
Conversation
mrazauskas
changed the title
process and processAsync to always return structured dataprocess() and processAsync() methods to always return structured data
There was a problem hiding this comment.
changelog entry? 😀 and https://github.com/facebook/jest/blob/main/docs/CodeTransformation.md needs some updates
EDIT: hah
|
can use this patch: facebook/react-native#33576 |
Great. I will try. Docs looked dated. Just could not stop myself. If that’s too much, I can open separate PR. |
| @@ -1,8 +1,17 @@ | |||
| diff --git a/jest/preprocessor.js b/jest/preprocessor.js | |||
There was a problem hiding this comment.
Yarn placed this file inside .yarn directory. Perhaps a good idea?
There was a problem hiding this comment.
yep, this is where it should be (new in yarn v3 there's a built in --save)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixing just another TODO. Transformer methods
processandprocessAsynccurrently are allowed to return a string or an object. As the comment states, perhaps it is fine to require to always return structured data:https://github.com/facebook/jest/blob/72ae96aed9865e7f24e6db89024ca7b04fe62cb9/packages/jest-transform/src/types.ts#L34-L37
Test plan
Code change was minimal, but I had to refactor lots of tests. All should pass.