Allowed describe and it/test to take in functions again #12484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
changed the title
|
Nice! CI seems happy 🙂 Can you add type tests as well? https://github.com/facebook/jest/blob/c65bb4521597fb1ad65dacd778a26e04684b2872/packages/jest-types/__typetests__/globals.test.ts
Runtime support is already test by the test you added in #5154, no? |
mrazauskas
reviewed
Feb 24, 2022
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
commented
Feb 24, 2022
|
Thank you for the pointers @SimenB! 🙌 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partially replicates DefinitelyTyped/DefinitelyTyped#23102 by allowing
describeto take in a number or function.Fixes #12483.
Test plan
I can verify TypeScript thinks these things are valid:
I couldn't figure out where the right place to test this at runtime is, though. Could someone help please? 🙂Actually, there are a bunch of compiler issues - I'll work on those.