refactor(jest-worker)!: allow only absolute workerPath
#12343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
approved these changes
Feb 9, 2022
|
Good. This came to my mind, just because you are doing lots of bundling refinements right now. I would like to add more validation, e.g. if |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
jest-workercontinued.It might be good idea to accept only absolute
workerPath.Right now the
BaseWorkerPoolclass if trying to resolve relativeworkerPathfromnode_modules/jest-worker/build/base/BaseWorkerPool.js. Seems like this might break ifjest-worker's build is bundled. Or I missed something?More over the main
Workerclass is requiring the sameworkerPathto be able detect exposed methods: https://github.com/facebook/jest/blob/b89a1bbe3652a3f5a8969ce768f3b74298ca021d/packages/jest-worker/src/index.ts#L31-L33Can the same relative path work in both of the classes, which live in different directories? Not sure. With absolute
workerPathall is clear and simple.Test plan
Tests should pass.