refactor(jest-jasmine2, jest-runtime): use Symbol to pass jest.setTimeout value instead of jasmine specific logic

[mrazauskas]

Summary

Currently jest-runtime still implements jasmine specific logic for jest.setTimeout function. It seems like simple refactor is enough to be able to use Symbol.for('TEST_TIMEOUT_SYMBOL') for both test runners (currently it is used only by jest-circus).

Benefits of this change: jest-runtime would have no jasmine specific code; hence, this would make possible to get rid of jasmine specific types as well. I have a draft for types too, but left it for separate PR.

There is no need of a change log entry in this case, right?

By the way, an alternative solution can be seen in the first commit. In this case jasmines private _DEFAULT_TIMEOUT_INTERVAL is replaced by global[testTimeoutSymbol] everywhere. All worked, but seemed more invasive and perhaps breaking too.

Test plan

The existing test suite should be sufficient.

[mrazauskas]

Setter is used by jasmine.DEFAULT_TIMEOUT_INTERVAL. Otherwise it is unnecessary here.

[codecov-commenter]

Codecov Report

Merging #12124 (6c1693e) into main (2f5a93d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #12124      +/-   ##
==========================================
- Coverage   67.26%   67.24%   -0.02%     
==========================================
  Files         330      330              
  Lines       17352    17355       +3     
  Branches     5071     5069       -2     
==========================================
- Hits        11672    11671       -1     
- Misses       5648     5652       +4     
  Partials       32       32              

Impacted Files	Coverage Δ
packages/jest-jasmine2/src/jasmine/jasmineLight.ts	0.00% <0.00%> (ø)
packages/jest-runtime/src/index.ts	55.51% <0.00%> (+0.19%)	⬆️
packages/expect/src/utils.ts	96.09% <0.00%> (-0.49%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f5a93d...6c1693e. Read the comment docs.

[SimenB]

This is a good change, but I'm a bit worried about landing it outside of a major release. What happens if somebody gets a newer version of jest-jasmine while still having old runtime? I assume setTimeout then just breaks.

Happy to land in Jest 28, tho 👍 (or 27 if I'm mistaken 😀)

[mrazauskas]

@SimenB Nice to see you are landing breaking changes. Should feel good (;

When the time comes for this PR, please take a look at the first commit. It is more breaking, but the code looks cleaner.

[SimenB]

I like it! 😀

changelog entry?

[SimenB]

👍

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.