[jest-haste-map] Use more optimal suffix-set format

[EvanBacon]

Summary

While looking through the code (expo-cli-(react-native)->metro->jest), I noticed that the syntax used here is specifically advised against in the watchman docs. I don't know enough about watchman to determine if these docs are incorrect, but @cpojer recommended opening a PR.

Test plan

Running the command locally works:

$ watchman -j <<-EOT                                                                        
["query", "./", {           
  "expression": ["allof",                
    ["type", "f"],      
    ["suffix", ["js", "json", "ts"]]
  ],                
  "fields": ["name", "exists", "mtime_ms", "size"]
}] 
EOT

[SimenB]

Should update the test and fix linting error.

That said, I know nothing of watchman 😅 @rickhanlonii is this something you can verify with somebody at FB?

[motiz88]

Looks like jest-haste-map already does some capability negotiation with Watchman:

https://github.com/facebook/jest/blob/bc50e7f360ab1845abbaa0b3ad788caead0d3174/packages/jest-haste-map/src/watchers/WatchmanWatcher.js#L175-L180

So for compatibility with older Watchman versions, let's check for the suffix-set capability first and otherwise fall back to the old behaviour.

Other than that, looks good!

[SimenB]

Thanks @motiz88!

[SimenB]

Changelog entry and updated tests and I think we're good to go 🙂

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.