docs: include French #11361
docs: include French #11361
Conversation
|
Makes sense to me 🙂 It doesn't show up in the dropdown, tho?
|
website/i18n.js
Outdated
| @@ -19,6 +19,9 @@ const localeConfigs = { | |||
| 'es-ES': { | |||
| label: 'Español', | |||
| }, | |||
| 'fr': { | |||
There was a problem hiding this comment.
You also need to add it to the locales array above
BTW it's now not-required to provide a local config, as Docusaurus provide default localized labels for each locale automatically
docs: Add fr to locale array to display in dropdown correctly
|
It's in the list now, but doesn't seem to work
That might just be the netlify preview only doing English, tho? I see the other langs are missing as well |
It's better
|
|
@SimenB For me it's normal, only the original doc works because it's a build for a preview. See dococusaurus docs:
|
website/i18n.js
Outdated
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| // The top-30 locales on Crowdin are enabled | |||
| // but we enable only a subset of those | |||
| const locales = ['en', 'ja', 'es-ES', 'pt-BR', 'ro', 'ru', 'uk', 'zh-Hans']; | |||
| const locales = ['en', 'ja', 'es-ES', 'fr', 'pt-BR', 'ro', 'ru', 'uk', 'zh-Hans']; | |||
There was a problem hiding this comment.
I don't understand the error for Typescript. Why is only 'fr' affected, should it be the case for the others too?
There was a problem hiding this comment.
it's not typescript, it's eslint since the line is too long
There was a problem hiding this comment.
just run prettier on the file and it should be happy 👍
There was a problem hiding this comment.
yarn prettier website/i18n.js --write should do the trick, not sure how you got double quotes 🙈
|
thanks @forresst! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Add French To website (Hello @slorber)
Test plan
Nope