fix: run GC before collecting open handles #11278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
force-pushed
the
open-handles-gc-run
branch
from
0aed689 to
cb6ae16
Compare
SimenB
added a commit
to Mr0grog/jest
that referenced
this pull request
May 20, 2021
SimenB
added a commit
to Mr0grog/jest
that referenced
this pull request
May 20, 2021
This reverts commit e5bd74f.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11275. I've pushed 2 commits, one that I hoped would fix the issue, and then one that removes the warning.
The first commit worked (probably just because it waited a tick, nothing to do with GC), but it also made the test that asserts we warn about unclosed servers not detect anything.
Test plan
Test added