Add support for AbortController in Jest Node environment with Node v15 #11182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This breaks the sandbox, but we already do it a bunch, so... I hope nodejs/node#28823 gets solved at some point. Can you add a changelog entry? |
|
I've now added a changelog entry, hope it's in the correct place 😄 |
it is 👍 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the AbortController global when using the
nodeJest environment with Nodev15.The motivation for this pull request is to fix the error
ReferenceError: AbortController is not definedwhen trying to test code that uses the AbortController in Node v15. This has previously been a Browser API but has now been introduced as a native API in Node v15.Test plan
This change is non-breaking. Node versions earlier than
v15will behave the same as before, throwing aReferenceErrorif you callAbortControllerwithout polyfilling it or using thejsdomenvironment.