feat(transform): pass config options through to transformer #10926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
force-pushed
the
pass-tranform-options-to-transform
branch
from
f143ce6 to
19e2a28
Compare
jeysal
added a commit
to mattphillips/jest
that referenced
this pull request
Dec 13, 2020
* master: (30 commits) chore: verify TS project references are correct (jestjs#10941) chore(deps): bump actions/setup-node from v2.1.2 to v2.1.3 (jestjs#10940) docs: Rectify typo in tutorialReactNative (jestjs#10930) chore: patch react-native jest preprocessor to avoid warning Ensure `toContain` only accepts strings when `received` is a string (jestjs#10929) chore: update lockfile after publish v27.0.0-next.2 Document and test custom, async, inline snapshot matcher (jestjs#10922) feat(transform): pass config options through to transformer (jestjs#10926) chore: bump eslint-config-prettier chore: run prettier using eslint chore: update lockfile after publish v27.0.0-next.1 fix: move binary file declaration from runtime to repl (jestjs#10925) chore(test-result): remove deprecated `sourcemap` property (jestjs#10355) chore: remove mapCoverage remainings; remove deprecated CLI options test (jestjs#9968) refactor(jest-runtime,jest-transform): add readonly for some class fields (jestjs#10918) chore: ensure single environment package as well chore: fix failing tests (jestjs#10924) chore: fix lint warning ...
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This should not be needed: https://github.com/aelbore/esbuild-jest/blob/1bf605ad7a338c47da16efd1df9439950de05fb6/src/index.ts#L15-L23. We've already resolved and cached it in Jest, so we should just pass it through
/cc @aelbore (for Jest 26 you can implement
createTransformerand get passed the options, fwiw)Test plan
Tweaked a test