feat: use modern fake timers by default #10874
Merged
+19
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fake promises test fails, which I think aligns with facebook/react-native#29303, but I didn't go into details, so may be wrong. |
SimenB
force-pushed
the
default-fake-timers
branch
2 times, most recently
from
d03c16a to
6744804
Compare
|
@thymikee dunno about that issue, the issue here is the test uses |
SimenB
force-pushed
the
default-fake-timers
branch
from
6744804 to
206602d
Compare
SimenB
force-pushed
the
default-fake-timers
branch
from
206602d to
e324312
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As announced in the v26 blog post
Test plan
Green CI