Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: show enhanced syntax error for all syntax errors #10749

Merged
merged 2 commits into from
Nov 4, 2020
Merged

chore: show enhanced syntax error for all syntax errors #10749

merged 2 commits into from
Nov 4, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Oct 31, 2020 •
edited
Loading

Summary

#6275 added this helpful error message, but it doesn't trigger on e.g. TLA.

Master:
image

While with this PR the enhancement triggers

image

Test plan

See above

@SimenB SimenB requested review from thymikee and jeysal October 31, 2020 13:30
@SimenB SimenB force-pushed the show-syntax-error branch from 47d58aa to 5fdf911 Compare October 31, 2020 14:00
@thymikee
Copy link
Collaborator

Hm, we'd need to tweak the wording because now it's not only about imported files, but the message implies so.

@SimenB
Copy link
Member Author

SimenB commented Oct 31, 2020

Hm, we'd need to tweak the wording because now it's not only about imported files, but the message implies so.

How so?

@thymikee
Copy link
Collaborator

The syntax error may happen in your test for example, which technically is imported by Jest, not a user.

I wonder if this is clearer? Let's keep in mind that this should be especially helpful for people not familiar with Jest transformers etc:

Syntax Error

Jest failed to parse a file. This happens e.g. when your code or its dependencies use a non-standard JavaScript syntax. Or when Jest is not configured to support such syntax. Out of the box Jest supports Babel, which will be used to transform your files into valid JS based on found Babel config.

By default "node_modules" folder is ignored from transformation.

Here's what you can do:

  • ...

@SimenB
Copy link
Member Author

SimenB commented Oct 31, 2020

I like it! @orta @rickhanlonii @jeysal thoughts?

@rickhanlonii
Copy link
Member

I love it!

@orta
Copy link
Member

orta commented Nov 4, 2020

plus one, this is a solid win

@SimenB SimenB force-pushed the show-syntax-error branch from 5fdf911 to 65111b2 Compare November 4, 2020 06:37
@SimenB
Copy link
Member Author

SimenB commented Nov 4, 2020

Pushed updated wording, slightly tweaking @thymikee's suggestion.

image

thymikee
thymikee approved these changes Nov 4, 2020
View reviewed changes
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SimenB SimenB merged commit abaa556 into jestjs:master Nov 4, 2020
@SimenB SimenB deleted the show-syntax-error branch November 4, 2020 10:42
jeysal added a commit to mmkal/jest that referenced this pull request Nov 8, 2020
@jeysal
Merge branch 'master' into uglier-inline-snapshots
13c960e 
* master: (398 commits)
  chore(breaking): remove undocumented `enabledTestsMap` config (jestjs#10787)
  Change expect.not.objectContaining() to match documentation (jestjs#10708)
  chore: add name to root project (jestjs#10782)
  Added explanation on how to use custom @jest-environment to docs (jestjs#10783)
  fix: remove deprecated functions from the jest object (jestjs#9853)
  chore: convert jest-runtime to ESM (jestjs#10325)
  fix(resolve): use escalade to find package.json (jestjs#10781)
  feat(jest-runner): set exit code to 1 if test logs after teardown (jestjs#10728)
  chore: add `exports` field to all `package.json`s (jestjs#9921)
  fix: do not inject `global` variable into module wrapper (jestjs#10644)
  chore: migrate jest-resolve to ESM (jestjs#10688)
  chore(transform): refactor API to pass an options bag around rather than multiple boolean options (jestjs#10753)
  chore: default to node test env rather than browser (jestjs#9874)
  fix: drop support for node 13 (jestjs#10685)
  chore: show enhanced syntax error for all syntax errors (jestjs#10749)
  chore: update lockfile after publish
  v26.6.3
  chore: update changelog for release
  Don't throw an error if mock dependency can't be found (jestjs#10779)
  chore: bump babel core types (jestjs#10772)
  ...
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thymikee thymikee thymikee approved these changes

@jeysal jeysal Awaiting requested review from jeysal

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SimenB @thymikee @rickhanlonii @orta @facebook-github-bot