Change expect.not.objectContaining() to match documentation #10708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninevra
changed the title
jeysal
approved these changes
Oct 26, 2020
SimenB
reviewed
Oct 26, 2020
ninevra
force-pushed
the
not-object-containing
branch
from
89bb9bf to
a6e5cb6
Compare
|
Nah, don't worry about that - mac CI something just decides to not work |
|
Since we reverted #10508, which parts of this should stay or go? My brain is currently mush, so I was unable to decipher it 😛 |
|
I think it just needs a rebase that applies the |
Asserts that ObjectNotContaining matches values which do not contain _all_ of the sample's properties. Asserts that ObjectNotContaining matches iff ObjectContaining does not match.
ninevra
force-pushed
the
not-object-containing
branch
from
a6e5cb6 to
708e68e
Compare
|
Rebased on master (2fa34c4). Moved one test case which relied on the now-reverted recursive behavior. |
jeysal
added a commit
to mmkal/jest
that referenced
this pull request
Nov 8, 2020
* master: (398 commits) chore(breaking): remove undocumented `enabledTestsMap` config (jestjs#10787) Change expect.not.objectContaining() to match documentation (jestjs#10708) chore: add name to root project (jestjs#10782) Added explanation on how to use custom @jest-environment to docs (jestjs#10783) fix: remove deprecated functions from the jest object (jestjs#9853) chore: convert jest-runtime to ESM (jestjs#10325) fix(resolve): use escalade to find package.json (jestjs#10781) feat(jest-runner): set exit code to 1 if test logs after teardown (jestjs#10728) chore: add `exports` field to all `package.json`s (jestjs#9921) fix: do not inject `global` variable into module wrapper (jestjs#10644) chore: migrate jest-resolve to ESM (jestjs#10688) chore(transform): refactor API to pass an options bag around rather than multiple boolean options (jestjs#10753) chore: default to node test env rather than browser (jestjs#9874) fix: drop support for node 13 (jestjs#10685) chore: show enhanced syntax error for all syntax errors (jestjs#10749) chore: update lockfile after publish v26.6.3 chore: update changelog for release Don't throw an error if mock dependency can't be found (jestjs#10779) chore: bump babel core types (jestjs#10772) ...
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10186 by changing
expect.not.objectContaining()to simply invert the result ofexpect.objectContaining().By semver this is a patch-level change, but I agree with jeysal that it would be prudent to treat this as a breaking change anyway, just in case someone's relying on the previous behavior.
Test plan
Revised existing tests which asserted undocumented behavior and added several new test cases.