Fix website's yarn start on Windows #3510
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a problem with the website's launching sequence on Windows when running
yarn start
. In some cases it seems to be necessary to replace the\n
character with the OS' specific one through node'sos.EOL
constant because the\r
character remains if just\n
gets replaced on a Windows (10) machine.The change in
feed.js
(TypeError: Cannot read property '1' of null
) actually brings the site back up whereas the change inconvert.js
displays the blog post preview texts (not displayed without the change).Test plan
N/A, only clicked it through on a Windows and Mac.