Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix website's yarn start on Windows #3510

Merged
merged 1 commit into from
May 8, 2017

Conversation

ndresx
Copy link
Contributor

@ndresx ndresx commented May 7, 2017

Summary
This PR fixes a problem with the website's launching sequence on Windows when running yarn start. In some cases it seems to be necessary to replace the \n character with the OS' specific one through node's os.EOL constant because the \r character remains if just \n gets replaced on a Windows (10) machine.

The change in feed.js (TypeError: Cannot read property '1' of null) actually brings the site back up whereas the change in convert.js displays the blog post preview texts (not displayed without the change).

Test plan
N/A, only clicked it through on a Windows and Mac.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

Codecov Report

Merging #3510 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3510   +/-   ##
=======================================
  Coverage   62.28%   62.28%           
=======================================
  Files         181      181           
  Lines        6700     6700           
  Branches        5        5           
=======================================
  Hits         4173     4173           
  Misses       2525     2525           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 992e991...4ec5800. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants