-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hermes "show source" not working in debug mode. #763
Comments
Possible duplicate of #612 |
It is not the same as it is not working no matter how many time i do changes to a file or reload. |
If you have a problem duplicating the problem, I could upload my project and remove all code from it. This problem happened when you update an old project to a new one. When I created a new expo bare project the debugging work somehow. |
For those of you wondering, I just tried reproducing this problem on React Native 0.71.3 and it is no longer valid on Android, but I am experiencing the issue on iOS. My basic reproduction scenario:
This implementation logs the following to the console regardless of weather I am in debug or release modes using Hermes engine:
|
The same issue. For me, it works normally in release. However, it won't work after downloading a new js bundle using |
@lchenfox Finally, I have found two solutions:
|
Thank u so much. I'll have a try on that. Hope it works after downloading and installing a new patch package using |
@congshengwu Unfortunately, I tried react-native-echarts-pro as you said above. It does not work with |
I also have almost the exact same problem (using highcharts instead of echarts) |
I already commented about this om #114 . Copying it here for visibility: In order to identify whether this is a problem in Hermes, we need to be able to examine the input given to Hermes. Unfortunately we can't help debug parts of the build pipeline that happen before Hermes. It is quite possible that the "show source" annotation is stripped before it gets to the Hermes compiler, for example by a minifier. |
Closing since no activity |
I am applying the label |
Bug Description
I recently Upgraded react-native to 0.68.2 and decided to use hermes.
as I have some library that uses
function toString
, then I decided to implementshow source
to those files it needed.Now this is not the problem.
The problem is that it is impossible to debug my app eg running
react-native run-android
as theshow source
do not work.it works fine when running
react-native run-android --variant=release
and everything works as expected.Is there is reason or settings I am missing ?
gradle clean
and confirmed this bug does not occur with JSCHermes version: 0.11.0
React Native version (if any): 0.68.2
OS version (if any): android 30
Platform (most likely one of arm64-v8a, armeabi-v7a, x86, x86_64): armeabi-v7a (not sure) it is an emulator using genymotion
Steps To Reproduce
The Expected Behavior
Should show the source code instead I am getting [bytecode]
I will also post my package.json as I think that it has something to do with it.
The text was updated successfully, but these errors were encountered: