From 8340357a00b11b9cf4c3f61bba9ce4dc2b05f414 Mon Sep 17 00:00:00 2001 From: Neil Dhar Date: Thu, 27 May 2021 16:35:17 -0700 Subject: [PATCH] Bump gradle version Summary: This diff updates the minimum gradle plugin version for building the Hermes OSS release in order to avoid problems in older versions of the Android NDK. Specifically, there was a bug (https://github.com/android/ndk/issues/1166) in the Android NDK that caused the exception handling functions in `libc++` to be incorrectly exported. Depending on link order, this can lead to `libhermes.so` not statically linking in `_Unwind_resume`, and expecting it instead to be resolved dynamically to the version in `libc++`. However, if we're linking against an RN version that was built against the new version of the NDK, those symbols may not be exported, and end up unresolved (which crashes the app). To allow Hermes to be built with newer versions of the NDK, we need to bump up the gradle plugin version to 4.1. RN already uses 4.1. Differential Revision: D28763472 fbshipit-source-id: 617749b2b50dbede29205ed43cc3862e36c14ac8 --- android/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/build.gradle b/android/build.gradle index b2eb61cb67e..8b27818665b 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -47,7 +47,7 @@ buildscript { jcenter() } dependencies { - classpath 'com.android.tools.build:gradle:4.0.0' + classpath 'com.android.tools.build:gradle:4.1.0' classpath("de.undercouch:gradle-download-task:4.0.2") } }