Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Require Interfaces to have 1+ Objects implementing #460

Closed
wants to merge 2 commits into from

Conversation

mjmahone
Copy link
Contributor

@mjmahone mjmahone commented Jun 8, 2018

Re-applies #424, but as an RFC. This change is a major spec breaking change, and if it is desire-able, we should provide an upgrade path for existing schemas.

Re-applies #424, but as an RFC. This change is a major spec breaking change, and if it is desireable, we should provide an upgrade path for existing schemas.
@mjmahone mjmahone added the RFC label Jun 8, 2018
@mjmahone mjmahone changed the title RFC: Require Interfaces to implement 1+ Objects RFC: Require Interfaces to have 1+ Objects implementing them Jun 8, 2018
@mjmahone mjmahone changed the title RFC: Require Interfaces to have 1+ Objects implementing them RFC: Require Interfaces to have 1+ Objects implementing Jun 8, 2018
@leebyron
Copy link
Collaborator

Thanks for putting this up - I'll add it as an agenda item for next week's WG session since it's notable

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@leebyron leebyron added 🗑 Rejected (RFC X) RFC Stage X (See CONTRIBUTING.md) and removed RFC labels Oct 2, 2018
@leebyron
Copy link
Collaborator

leebyron commented Oct 2, 2018

We forgot to address this at the WG meeting, but I think the concerns encountered warrant rejecting this proposal. Thanks for the careful revert and re-RFC, @mjmahone!

@leebyron leebyron closed this Oct 2, 2018
@leebyron leebyron deleted the rfc-interfaces-implemented branch October 2, 2018 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗑 Rejected (RFC X) RFC Stage X (See CONTRIBUTING.md)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants