Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using OkHttp -- Docs clarification... #18

Closed
philipbjorge opened this issue Mar 28, 2015 · 5 comments
Closed

Using OkHttp -- Docs clarification... #18

philipbjorge opened this issue Mar 28, 2015 · 5 comments

Comments

@philipbjorge
Copy link

So I'm reading the docs on using OkHttp and it indicates that my gradle file should not have compile 'com.facebook.fresco:fresco:0.1.0+' if I'm trying to use Fresco with OkHttp. However, unless I add that dependency, I have no Fresco to initialize.

Should I be including three dependencies as follows? If so, I think the docs could be clearer...

    compile 'com.facebook.fresco:fresco:0.1.0+'
    compile "com.facebook.fresco:drawee:0.1.0+"
    compile "com.facebook.fresco:imagepipeline-okhttp:0.1.0+"

http://frescolib.org/docs/using-other-network-layers.html#_

@philipbjorge philipbjorge changed the title Using OkHttp... Using OkHttp -- Docs clarification... Mar 28, 2015
@plamenko
Copy link
Contributor

Thank you, there was a typo in the documentation. The following should be enough:

compile 'com.facebook.fresco:fresco:0.1.0+'
compile "com.facebook.fresco:imagepipeline-okhttp:0.1.0+"

@philipbjorge
Copy link
Author

Awesome -- Thanks for the prompt response.

@qq157755587
Copy link

It looks there is still a type.

compile: "com.facebook.fresco:fresco:0.1.0+"
compile: "com.facebook.fresco:imagepipeline-okhttp:0.1.0+"

should be

compile 'com.facebook.fresco:fresco:0.1.0+'
compile 'com.facebook.fresco:imagepipeline-okhttp:0.1.0+'

@broakenmedia
Copy link

the imagepipeline-okhttp also seems to have missing classes namely:

java.lang.NoSuchMethodError: com.squareup.okhttp.OkHttpClient.open
at com.squareup.okhttp.OkUrlFactory.open(OkUrlFactory.java:44)

@michalgr
Copy link
Contributor

@xbroak : would you mind creating separate issue for the missing class ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants