From 3cfdae01b126bba0c15213a23a310097974ef564 Mon Sep 17 00:00:00 2001
From: Denis Yaroshevskiy <dyaroshev@meta.com>
Date: Wed, 31 Jul 2024 04:25:04 -0700
Subject: [PATCH] move folly::is_instantiation_of_v out of detail

Summary: since we want a publicly facing concept, remove detail

Reviewed By: jagill, yfeldblum

Differential Revision: D60284223

fbshipit-source-id: 38c3fc12991d42891342f9cdb89814fd4d1f2420
---
 folly/Function.h                      | 2 +-
 folly/Replaceable.h                   | 2 +-
 folly/Traits.h                        | 4 ----
 folly/container/Array.h               | 2 +-
 folly/container/sorted_vector_types.h | 4 ++--
 folly/coro/Traits.h                   | 7 +++----
 folly/fibers/async/Async.h            | 2 +-
 folly/test/TraitsTest.cpp             | 8 ++++----
 8 files changed, 13 insertions(+), 18 deletions(-)

diff --git a/folly/Function.h b/folly/Function.h
index 6fc733a096a..8bcefff1f46 100644
--- a/folly/Function.h
+++ b/folly/Function.h
@@ -612,7 +612,7 @@ using DispatchOf = Dispatch<
 // `Function` there refers to the instantion and not the template.
 template <typename T>
 constexpr bool is_instantiation_of_folly_function_v =
-    detail::is_instantiation_of_v<Function, T>;
+    is_instantiation_of_v<Function, T>;
 
 } // namespace function
 } // namespace detail
diff --git a/folly/Replaceable.h b/folly/Replaceable.h
index 233ea1e4026..5ce2910fe1a 100644
--- a/folly/Replaceable.h
+++ b/folly/Replaceable.h
@@ -373,7 +373,7 @@ struct is_convertible_from_replaceable
 } // namespace replaceable_detail
 
 template <class T>
-using is_replaceable = detail::is_instantiation_of<Replaceable, T>;
+using is_replaceable = is_instantiation_of<Replaceable, T>;
 
 // Function to make a Replaceable with a type deduced from its input
 template <class T>
diff --git a/folly/Traits.h b/folly/Traits.h
index 3b467411f23..3c6b86e1301 100644
--- a/folly/Traits.h
+++ b/folly/Traits.h
@@ -157,8 +157,6 @@ inline constexpr bool is_bounded_array_v<T[S]> = true;
 template <typename T>
 struct is_bounded_array : std::bool_constant<is_bounded_array_v<T>> {};
 
-namespace detail {
-
 /// is_instantiation_of_v
 /// is_instantiation_of
 ///
@@ -176,8 +174,6 @@ template <template <typename...> class C, typename... T>
 struct is_instantiation_of
     : std::bool_constant<is_instantiation_of_v<C, T...>> {};
 
-} // namespace detail
-
 /// member_pointer_traits
 ///
 /// For a member-pointer, reveals its constituent member-type and object-type.
diff --git a/folly/container/Array.h b/folly/container/Array.h
index 55c45fc4c2d..c4d1a64cbef 100644
--- a/folly/container/Array.h
+++ b/folly/container/Array.h
@@ -34,7 +34,7 @@ namespace folly {
 
 namespace array_detail {
 template <class T>
-using is_ref_wrapper = detail::is_instantiation_of<std::reference_wrapper, T>;
+using is_ref_wrapper = is_instantiation_of<std::reference_wrapper, T>;
 
 template <typename T>
 using not_ref_wrapper =
diff --git a/folly/container/sorted_vector_types.h b/folly/container/sorted_vector_types.h
index 88082e374ac..10b078dfeb9 100644
--- a/folly/container/sorted_vector_types.h
+++ b/folly/container/sorted_vector_types.h
@@ -859,7 +859,7 @@ inline void swap(
 
 template <typename T>
 inline constexpr bool is_sorted_vector_set_v =
-    detail::is_instantiation_of_v<sorted_vector_set, T>;
+    is_instantiation_of_v<sorted_vector_set, T>;
 
 template <typename T>
 struct is_sorted_vector_set : std::bool_constant<is_sorted_vector_set_v<T>> {};
@@ -1618,7 +1618,7 @@ inline void swap(
 
 template <typename T>
 inline constexpr bool is_sorted_vector_map_v =
-    detail::is_instantiation_of_v<sorted_vector_map, T>;
+    is_instantiation_of_v<sorted_vector_map, T>;
 
 template <typename T>
 struct is_sorted_vector_map : std::bool_constant<is_sorted_vector_map_v<T>> {};
diff --git a/folly/coro/Traits.h b/folly/coro/Traits.h
index 3953352aaec..fdf57b410f6 100644
--- a/folly/coro/Traits.h
+++ b/folly/coro/Traits.h
@@ -43,10 +43,9 @@ using remove_reference_wrapper_t = typename remove_reference_wrapper<T>::type;
 namespace detail {
 
 template <typename T>
-inline constexpr bool is_coroutine_handle_v =
-    folly::detail::is_instantiation_of_v< //
-        coroutine_handle,
-        T>;
+inline constexpr bool is_coroutine_handle_v = folly::is_instantiation_of_v< //
+    coroutine_handle,
+    T>;
 
 } // namespace detail
 
diff --git a/folly/fibers/async/Async.h b/folly/fibers/async/Async.h
index c1d9e227059..a3f75820222 100644
--- a/folly/fibers/async/Async.h
+++ b/folly/fibers/async/Async.h
@@ -157,7 +157,7 @@ inline void init_await(Async<void>&& async) {
 
 // is_async
 template <typename T>
-constexpr bool is_async_v = folly::detail::is_instantiation_of_v<Async, T>;
+constexpr bool is_async_v = folly::is_instantiation_of_v<Async, T>;
 
 // async_inner_type
 template <typename T>
diff --git a/folly/test/TraitsTest.cpp b/folly/test/TraitsTest.cpp
index 4ef8575b002..3b6f395ddb3 100644
--- a/folly/test/TraitsTest.cpp
+++ b/folly/test/TraitsTest.cpp
@@ -547,13 +547,13 @@ TEST(Traits, isBoundedArrayV) {
 }
 
 TEST(Traits, isInstantiationOfV) {
-  EXPECT_TRUE((detail::is_instantiation_of_v<A, A<int>>));
-  EXPECT_FALSE((detail::is_instantiation_of_v<A, B>));
+  EXPECT_TRUE((is_instantiation_of_v<A, A<int>>));
+  EXPECT_FALSE((is_instantiation_of_v<A, B>));
 }
 
 TEST(Traits, isInstantiationOf) {
-  EXPECT_TRUE((detail::is_instantiation_of<A, A<int>>::value));
-  EXPECT_FALSE((detail::is_instantiation_of<A, B>::value));
+  EXPECT_TRUE((is_instantiation_of<A, A<int>>::value));
+  EXPECT_FALSE((is_instantiation_of<A, B>::value));
 }
 
 TEST(Traits, member_pointer_traits_data) {