From 216baa676dcb17b1a7ef448944d9fd4484c3bb62 Mon Sep 17 00:00:00 2001 From: Yedidya Feldblum Date: Sun, 23 Jun 2024 06:43:30 -0700 Subject: [PATCH] cut unnecessary function-exports in StaticMeta Summary: These uses of `FOLLY_EXPORT` are vestigial from when these member functions had their own local `thread_local`s. But now that is wrapped up in member function `getLocalCache`, so all other uses no longer need it. Differential Revision: D58916971 fbshipit-source-id: 9e0a3db2485baee203675e75eeadb2eebe76a5f2 --- folly/detail/ThreadLocalDetail.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/folly/detail/ThreadLocalDetail.h b/folly/detail/ThreadLocalDetail.h index 8ee4fca54e4..ea4660ae704 100644 --- a/folly/detail/ThreadLocalDetail.h +++ b/folly/detail/ThreadLocalDetail.h @@ -562,7 +562,7 @@ struct FOLLY_EXPORT StaticMeta final : StaticMetaBase { return instance; } - FOLLY_EXPORT FOLLY_ALWAYS_INLINE static ElementWrapper& get(EntryID* ent) { + FOLLY_ALWAYS_INLINE static ElementWrapper& get(EntryID* ent) { // Eliminate as many branches and as much extra code as possible in the // cached fast path, leaving only one branch here and one indirection // below. @@ -582,8 +582,7 @@ struct FOLLY_EXPORT StaticMeta final : StaticMetaBase { * StaticMetaBase::allId2ThreadEntrySets_ updated with ThreadEntry* whenever a * ThreadLocal is set/released. */ - FOLLY_EXPORT FOLLY_ALWAYS_INLINE static ThreadEntry* getThreadEntry( - EntryID* ent) { + FOLLY_ALWAYS_INLINE static ThreadEntry* getThreadEntry(EntryID* ent) { // Eliminate as many branches and as much extra code as possible in the // cached fast path, leaving only one branch here and one indirection below. uint32_t id = ent->getOrInvalid();