Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.4 compatibility issues #2822

Open
layoutd opened this issue Nov 5, 2024 · 0 comments · May be fixed by #2832
Open

PHP 8.4 compatibility issues #2822

layoutd opened this issue Nov 5, 2024 · 0 comments · May be fixed by #2832
Assignees
@brezocordero
Labels
compatibility type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@layoutd
Copy link
Contributor

layoutd commented Nov 5, 2024 •
edited
Loading

As part of #2821, some deprecated messages appeared in the logs:

Activating Extension

Deprecated: WC_Facebookcommerce_Integration::create_product_simple(): Implicitly marking parameter $fb_product_group_id as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/wp-content/plugins/facebook-for-woocommerce/facebook-commerce.php on line 1210`

Viewing WooCommerce Categories

PHP Deprecated:  WooCommerce\Facebook\Admin\Enhanced_Catalog_Attribute_Fields::__construct(): Implicitly marking parameter $term as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/wp-content/plugins/facebook-for-woocommerce/includes/Admin/Enhanced_Catalog_Attribute_Fields.php on line 50
PHP Deprecated:  WooCommerce\Facebook\Admin\Enhanced_Catalog_Attribute_Fields::__construct(): Implicitly marking parameter $product as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/wp-content/plugins/facebook-for-woocommerce/includes/Admin/Enhanced_Catalog_Attribute_Fields.php on line 50
@layoutd layoutd mentioned this issue Nov 5, 2024
Closed
39 tasks
@rawdreeg rawdreeg added compatibility type: technical debt This issue/PR represents/solves the technical debt of the project. labels Nov 14, 2024
@brezocordero brezocordero self-assigned this Nov 22, 2024
@brezocordero brezocordero linked a pull request Nov 23, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brezocordero brezocordero

Labels
compatibility type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PHP 8.4 remove warnings from implicitly nullable parameters facebook/facebook-for-woocommerce
3 participants
@layoutd @rawdreeg @brezocordero