Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The swizzle CLI should prompt for TS usage #9402

Closed
1 task done
slorber opened this issue Oct 13, 2023 · 1 comment · Fixed by #9681
Closed
1 task done

The swizzle CLI should prompt for TS usage #9402

slorber opened this issue Oct 13, 2023 · 1 comment · Fixed by #9681
Labels
apprentice Issues that are good candidates to be handled by a Docusaurus apprentice / trainee proposal This issue is a proposal, usually non-trivial change

Comments

@slorber
Copy link
Collaborator

slorber commented Oct 13, 2023 •
edited
Loading

Have you read the Contributing Guidelines on issues?

Motivation

When using the swizzle CLI, we can get TypeScript copies of the theme files, but this requires to provide the --typescript option ahead of time.

yarn workspace website swizzle // will always copy JS files

yarn workspace website swizzle --typescript // will copy TS files, if available

When running yarn workspace website swizzle, the CLI should more interactive and promp the user if they want to use TypeScript.

To disable the promp, a language should be provided explicitly:

yarn workspace website swizzle --javascript
yarn workspace website swizzle --typescript

Related to #9401 (DX should be consistent)
@slorber slorber added proposal This issue is a proposal, usually non-trivial change apprentice Issues that are good candidates to be handled by a Docusaurus apprentice / trainee labels Oct 13, 2023
@slorber slorber mentioned this issue Oct 13, 2023
Closed
1 task
@slorber slorber assigned slorber and unassigned slorber Oct 13, 2023
@Josh-Cena Josh-Cena changed the title The swizzle CLI should promp for TS usage The swizzle CLI should prompt for TS usage Oct 13, 2023
@mqshaikh8
Copy link

Is anyone working on this? I would love to work on this if no one took it yet

@slorber slorber mentioned this issue Oct 24, 2023
Merged
1 task
@yixiaojiu yixiaojiu mentioned this issue Dec 29, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
apprentice Issues that are good candidates to be handled by a Docusaurus apprentice / trainee proposal This issue is a proposal, usually non-trivial change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(swizzle): ask user preferred language if no language CLI option provided yixiaojiu/docusaurus
2 participants
@slorber @mqshaikh8