-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy admonition keywords #9307
Comments
FYI AsciiDoc uses both warning and caution. https://docs.asciidoctor.org/asciidoc/latest/blocks/admonitions/
In the distant future, it would be nice if a remark-compatible AsciiDoc parser would appear and get supported by Docusaurus. (This is just my personal ideal though) |
I have no authority but I believe manuals of many (physical) products use both cautions and warnings. From: https://www.muirgraphics.com/2016/08/difference-life-death-choosing-right-safety-signal-words/ From: http://www.overheadlifting.org/understanding-safety-signs-and-overhead-lifting-equipment-hazards/ I'd like to and I believe we can use both in software manuals depending on severity, too. Or do you want us to substitute |
If we keep caution, we should adjust the hues of "warning" and "caution" because they share the same icon ⚠; "warning" should be closer to red and "caution" can be closer to yellow.
If we could keep it, we'll have to change the icon from 💡 to ✔ at least.
A warm color could be better, but I don't know what color is best (possibly non-warm color). At lease the current aqua seems different from what I want "important" admonition to be,
I don't know how and where I should use it instead of the others. |
|
https://infima.dev/docs/components/alert I guess we have no choice but to follow these classifications...
For caution, it seems the best to treat it as an alias for warning. I'll recommend readers of our documents to write |
Just FYI - GitHub has Note, Tip, Important, Warning, and Caution for their alerts: https://github.blog/changelog/2023-12-14-new-markdown-extension-alerts-provide-distinctive-styling-for-significant-content/. This matches the Microsoft Learn alerts: https://learn.microsoft.com/en-us/contribute/content/markdown-reference#alerts-note-tip-important-caution-warning No official request to keep; just sharing data points as I came across this. |
One more vote for keeping both Warning and Caution. Providing config options instead of swizzling sounds like the cherry on top, but even if we have that, Warning and Caution should be part of the default options IMHO. In general, Warning is tied to physical danger. Caution is of similar weight, suggesting things could go very wrong, but without any direct risk of physical injury. Cisco, for one, uses both in its documentation. VMware, being a pure software company, guides for using Caution exclusively. These are two examples of companies I've worked at. |
Have you read the Contributing Guidelines on issues?
Motivation
We historically have admonition keyword "aliases" that we don't even document since v2.0.
Those came from an old v2 dependency: https://github.com/elviswolcott/remark-admonitions
In Docusaurus v4 is time to remove them officially and throw an error for sites that still use them.
Note: in Docusaurus v3 we made
:::warning
the official admonition, and:::caution
an alias to remove in v4 (see #7558)EDIT: maybe we should have some kind of
siteConfig.markdown.admonitions
config and probably let users define their own set of directive/icon/color/label without requiring swizzling anything?Self-service
The text was updated successfully, but these errors were encountered: