Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The announcementBar cannot be translated #8196

Closed
5 of 7 tasks
Selflocking opened this issue Oct 9, 2022 · 1 comment
Closed
5 of 7 tasks

The announcementBar cannot be translated #8196

Selflocking opened this issue Oct 9, 2022 · 1 comment
Labels
closed: duplicate This issue or pull request already exists in another issue or pull request

Comments

@Selflocking
Copy link

Selflocking commented Oct 9, 2022

Have you read the Contributing Guidelines on issues?

Prerequisites

  • I'm using the latest version of Docusaurus.
  • I have tried the npm run clear or yarn clear command.
  • I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
  • I have tried creating a repro with https://new.docusaurus.io.
  • I have read the console error message carefully (if applicable).

Description

Run yarn write-translations, announcementBar does not appear on i18n/en/, so currently the announcementBar cannot be translated

Reproducible demo

https://docusaurus.io/zh-CN/

Steps to reproduce

yarn write-translations

Expected behavior

the announcementBar can be translated

Actual behavior

announcementBar does not appear on i18n/en/

Your environment

No response

Self-service

  • I'd be willing to fix this bug myself.
@Selflocking Selflocking added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Oct 9, 2022
@Josh-Cena
Copy link
Collaborator

Duplicate of #4542. This is so far untranslatable because we allow raw HTML so if you outsource your translations to an external workflow you risk XSS. We need to see how to harden the security so only pure decorative markup is tolerated.

@Josh-Cena Josh-Cena closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2022
@Josh-Cena Josh-Cena added closed: duplicate This issue or pull request already exists in another issue or pull request and removed bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed: duplicate This issue or pull request already exists in another issue or pull request
Projects
None yet
Development

No branches or pull requests

2 participants