Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing doctype on pages #383

Closed
Tonours opened this issue Jan 8, 2018 · 3 comments
Closed

Missing doctype on pages #383

Tonours opened this issue Jan 8, 2018 · 3 comments
Labels
bug An error in the Docusaurus core causing instability or issues with its execution

Comments

@Tonours
Copy link

Tonours commented Jan 8, 2018

Is this a bug report?

Yes, when markdown files are generated to html one we expect that it will include a doctype for the generated file.

Environment

OS: OSX 10.12.6
Node: 8.9.3
Npm: 5.5.1
Yarn: 1.3.2

Steps to Reproduce

  1. Clone Docusaurus repository
  2. Go to ./website run yarn install && yarn build
  3. Go to ./website/build/*.html

Expected Behavior

When build markdown to html files, html files should have a doctype.

Actual Behavior

When markdown files are generated to html one we expect that it will include a doctype for the generated file.

Reproducible Demo

Go to https://docusaurus.io/ and view source.

@Tonours
Copy link
Author

Tonours commented Jan 8, 2018

Hi !
As i have time today, i have made a pull-request for this #382 :-)

@JoelMarcey JoelMarcey added the bug An error in the Docusaurus core causing instability or issues with its execution label Feb 27, 2018
@JoelMarcey
Copy link
Contributor

@Tonours Hi. I debated whether to call this a bug or feature request -- called it a bug. I know your PR has been sitting around for a while, but I am still debating whether there is a cleaner way we can accomplish it. But, maybe we just have to go with it.

@yangshun
Copy link
Contributor

Closed by #566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution
Projects
None yet
Development

No branches or pull requests

3 participants