Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin-pwa: Usage of placeholders in manifest.json allowing implementation of manifest.json for different deployment environments #10458

Open
2 tasks done
martinjurran opened this issue Aug 30, 2024 · 1 comment
Labels
documentation The issue is related to the documentation of Docusaurus help wanted Asking for outside help and/or contributions to this particular issue or PR.

Comments

@martinjurran
Copy link

Have you read the Contributing Guidelines on issues?

Description

Hello everyone,

I have noticed that users of the plugin-pwa often have to create manifest.json files for different environments, but this process is currently undocumented.

There are at least two possible approaches to this issue:

  1. Create separate manifest.env.json files for each environment and copy the appropriate file during the build process.

  2. Use a single manifest.json file that includes placeholders, which can be handled by Workbox options and passed to workbox.injectManifest().

Lets open further discussion on this topic and gather additional suggestions to on how to implement manifest.json for different environments.

Current Documentation: https://github.com/facebook/docusaurus/edit/main/website/docs/api/plugins/plugin-pwa.mdx

Thank you

Self-service

  • I'd be willing to address this documentation request myself.
@martinjurran martinjurran added documentation The issue is related to the documentation of Docusaurus status: needs triage This issue has not been triaged by maintainers labels Aug 30, 2024
@Josh-Cena
Copy link
Collaborator

Welcoming any edits to the doc that you've verified works. I don't think any of us here is experienced with PWAs.

@Josh-Cena Josh-Cena added help wanted Asking for outside help and/or contributions to this particular issue or PR. and removed status: needs triage This issue has not been triaged by maintainers labels Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation The issue is related to the documentation of Docusaurus help wanted Asking for outside help and/or contributions to this particular issue or PR.
Projects
None yet
Development

No branches or pull requests

2 participants