From 4868a6c4d33722534e2174cd9848c4c5be22b4ca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Szabo?= Date: Fri, 23 Aug 2019 09:38:46 +0200 Subject: [PATCH 1/2] Minor performance improvements - use ESLint cache - disable syntactic errors check in fork-ts-checker - remove useless `watch` option in fork-ts-checker --- packages/react-scripts/config/webpack.config.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-scripts/config/webpack.config.js b/packages/react-scripts/config/webpack.config.js index 12157a390b8..dc5eb9cd85c 100644 --- a/packages/react-scripts/config/webpack.config.js +++ b/packages/react-scripts/config/webpack.config.js @@ -334,6 +334,7 @@ module.exports = function(webpackEnv) { use: [ { options: { + cache: true, formatter: require.resolve('react-dev-utils/eslintFormatter'), eslintPath: require.resolve('eslint'), resolvePluginsRelativeTo: __dirname, @@ -673,7 +674,7 @@ module.exports = function(webpackEnv) { }), async: isEnvDevelopment, useTypescriptIncrementalApi: true, - checkSyntacticErrors: true, + checkSyntacticErrors: false, resolveModuleNameModule: process.versions.pnp ? `${__dirname}/pnpTs.js` : undefined, @@ -688,7 +689,6 @@ module.exports = function(webpackEnv) { '!**/src/setupProxy.*', '!**/src/setupTests.*', ], - watch: paths.appSrc, silent: true, // The formatter is invoked directly in WebpackDevServerUtils during development formatter: isEnvProduction ? typescriptFormatter : undefined, From 04fbd999d6b8932dd80c30f3dfa125071e5fd30c Mon Sep 17 00:00:00 2001 From: Ian Schmitz Date: Tue, 10 Sep 2019 22:10:54 -0700 Subject: [PATCH 2/2] Revert checkSyntacticErrors change --- packages/react-scripts/config/webpack.config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/config/webpack.config.js b/packages/react-scripts/config/webpack.config.js index dc5eb9cd85c..f2815cac78c 100644 --- a/packages/react-scripts/config/webpack.config.js +++ b/packages/react-scripts/config/webpack.config.js @@ -674,7 +674,7 @@ module.exports = function(webpackEnv) { }), async: isEnvDevelopment, useTypescriptIncrementalApi: true, - checkSyntacticErrors: false, + checkSyntacticErrors: true, resolveModuleNameModule: process.versions.pnp ? `${__dirname}/pnpTs.js` : undefined,