Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe add jest to dev dependencies? #791

Comments

@kasperpeulen
Copy link
Contributor

There is no jest in dev-dependencies. I'm not sure if it is good idea to hide this. For example, I get this error message when installing the type definition of jest:

⇒  flow-typed install jest        
• Found flow-bin@v0.32.0 installed. Installing libdefs compatible with this version of Flow...
ERROR: Please specify an npm package name of the format 'foo@1.2.3'

But it is not trivial to find out now which version of jest I'm actually using.

@gaearon
Copy link
Contributor

gaearon commented Sep 28, 2016

We should have a better integration with flow-typed. cc @thejameskyle

In the meantime, you can learn your Jest version by checking jest in dependencies of node_modules/react-scripts/package.json.

@gaearon
Copy link
Contributor

gaearon commented Sep 30, 2016

Going to close this in favor of #453.

@gaearon gaearon closed this as completed Sep 30, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.