-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update webpack to fix dynamic imports #7254
Comments
I didn't realize this issue had been fixed in webpack. Thanks for pointing that out. We'll try and get a new version released in the next few days, provided the webpack upgrade doesn't introduce any other issues. |
In case anyone comes across this issue, this won't affect new installs. If you have an existing install you can try removing |
This does not work for our project, the problem is till there. |
This should work @lucamartini, did you check what Webpack version you had installed? |
it works with yarn, but not with npm. |
That's interesting. And not what I would have expected... it's not ideal, but you could also update @iansu, this might warrant a quick patch-release. |
I created a new CRA+TS project a couple days ago. I got Any news on getting this out as an update? |
@markerikson it should be next week. |
Warning: Dirty dirty solution below This is what I did to temporarily solve this issue In the root of my CRA project:
The last step is needed for CRA's preflight check to pass |
Or use Yarn's "resolutions" to force the use of an updated Webpack version: https://yarnpkg.com/lang/en/docs/selective-version-resolutions/ |
Had to automate this step for our CI setup. Added a
|
@Tobbe, you shouldn't need to do that. Are you in npm or Yarn? |
@mrmckeb I'm using npm
|
This is fixed and will be released in 3.1 so I'm going to close this issue. |
In v3.0.1, using webpack@4.29.6, dynamic imports fail. See the issue here. The issue's been fixed since 4.30.0, with the latest current version at 4.35.0
When will react-scripts be updated with the fixed version of webpack? I imagine it's a simple dependency update, but I don't know how the latest version will affect CRA
The text was updated successfully, but these errors were encountered: